Revert "Remove ref project from Microsoft.AspNetCore.Testing" #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b624d6b.
|
Huh? @JunTaoLuo did this to fix a problem that sounds a lot like dotnet/aspnetcore#18434. Would prefer to revert the workaround for the same problem checked into dotnet/aspnetcore. Put another way, the "Remove ref project from Microsoft.AspNetCore.Testing" change was correct and addressed more than just a useless project. |
@dougbu do you know offhand what the workaround in AspNetCore is? I'd also prefer to revert that, but wasn't able to remember what (if anything) we did to workaround this in AspNetCore, which presumably caused the failure in that repo once we ingested John's change |
No, it's not coming to me. I remember lots of warning suppressions but there was something else (perhaps instead of the warning suppressions?). I'll look tomorrow if you haven't figured it out by then. |
wtgodbe
added a commit
that referenced
this pull request
Jan 30, 2020
wtgodbe
added a commit
that referenced
this pull request
Feb 4, 2020
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 12, 2020
…extensions#2817)" (dotnet/extensions#2882) This reverts commit dotnet/extensions@b624d6b.\n\nCommit migrated from dotnet/extensions@1286a6f
wtgodbe
added a commit
that referenced
this pull request
Feb 13, 2020
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 15, 2020
…extensions#2817)" (dotnet/extensions#2882) This reverts commit dotnet/extensions@b624d6b.\n\nCommit migrated from dotnet/extensions@1286a6f
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Feb 28, 2020
…extensions#2817)" (dotnet/extensions#2882) This reverts commit b624d6ba91b9c292ff9a2aa786a575b0eaa31b4b. Commit migrated from dotnet/extensions@1286a6f
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Feb 28, 2020
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936) This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08. Commit migrated from dotnet/extensions@7a077d4
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 2, 2020
…extensions#2817)" (dotnet/extensions#2882) This reverts commit b624d6ba91b9c292ff9a2aa786a575b0eaa31b4b. Commit migrated from dotnet/extensions@1286a6f
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 2, 2020
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936) This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08. Commit migrated from dotnet/extensions@7a077d4
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
…extensions#2817)" (dotnet/extensions#2882) This reverts commit b624d6ba91b9c292ff9a2aa786a575b0eaa31b4b. Commit migrated from dotnet/extensions@1286a6f
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936) This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08. Commit migrated from dotnet/extensions@7a077d4
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
…extensions#2817)" (dotnet/extensions#2882) This reverts commit b624d6ba91b9c292ff9a2aa786a575b0eaa31b4b. Commit migrated from dotnet/extensions@1286a6f
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936) This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08. Commit migrated from dotnet/extensions@7a077d4
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 25, 2020
…extensions#2817)" (dotnet/extensions#2882) This reverts commit b624d6ba91b9c292ff9a2aa786a575b0eaa31b4b. Commit migrated from dotnet/extensions@1286a6f
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 25, 2020
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936) This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08. Commit migrated from dotnet/extensions@7a077d4
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
…extensions#2817)" (dotnet/extensions#2882) This reverts commit b624d6ba91b9c292ff9a2aa786a575b0eaa31b4b. Commit migrated from dotnet/extensions@1286a6f
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936) This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08. Commit migrated from dotnet/extensions@7a077d4
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2817
This broke AspNetCore (see dotnet/aspnetcore#18434):
Reverting it in order to get a candidate build for 3.1.2. We can always un-revert it if there's an obvious fix that lets us take this change without jeopardizing the release schedule.
CC @JunTaoLuo @dougbu @Pilchie @mmitche