Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ref project from Microsoft.AspNetCore.Testing #2817

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Remove ref project from Microsoft.AspNetCore.Testing #2817

merged 1 commit into from
Jan 16, 2020

Conversation

JunTaoLuo
Copy link

Adresses #2784

@JunTaoLuo JunTaoLuo requested a review from a team January 1, 2020 01:14
@JunTaoLuo
Copy link
Author

I'm curious whether there are any other ramifications for this change. We'll need to test building with this change in AspNetCore.

@JunTaoLuo
Copy link
Author

FYI, I spoke with @wtgodbe and we already have workarounds in place so we don't need this PR for correctness. It's for cleaning up only. I won't be putting this under servicing consider, but will include it in a future patch as a tell mode infrastructure change.

@JunTaoLuo JunTaoLuo changed the base branch from release/3.0 to release/3.1 January 10, 2020 01:20
@JunTaoLuo JunTaoLuo changed the base branch from release/3.1 to release/3.0 January 10, 2020 01:20
@JunTaoLuo JunTaoLuo changed the base branch from release/3.0 to release/3.1 January 10, 2020 01:26
@Pilchie
Copy link
Member

Pilchie commented Jan 16, 2020

@JunTaoLuo Are we taking this for 3.1.2?

@dougbu
Copy link
Member

dougbu commented Jan 16, 2020

@JunTaoLuo Aren't the "workarounds" hacks that we should cleanup outside and separate from a security update? Since we have this ready, my preference is to take this now.

@JunTaoLuo JunTaoLuo added this to the 3.1.2 milestone Jan 16, 2020
@JunTaoLuo
Copy link
Author

Yes we should be taking this in 3.1.2. It's a cleanup item.

@JunTaoLuo JunTaoLuo merged commit b624d6b into release/3.1 Jan 16, 2020
@JunTaoLuo JunTaoLuo deleted the johluo/remove-testing-ref branch January 16, 2020 00:36
@wtgodbe wtgodbe mentioned this pull request Jan 18, 2020
Merged
wtgodbe added a commit that referenced this pull request Jan 18, 2020
@wtgodbe
Revert "Remove ref project from Microsoft.AspNetCore.Testing (#2817)"
c46cf14 
This reverts commit b624d6b.
@wtgodbe wtgodbe mentioned this pull request Jan 18, 2020
Merged
wtgodbe added a commit that referenced this pull request Jan 18, 2020
@wtgodbe
Revert "Remove ref project from Microsoft.AspNetCore.Testing (#2817)" (…
1286a6f 
…#2882)

This reverts commit b624d6b.
wtgodbe added a commit that referenced this pull request Jan 30, 2020
@wtgodbe
Revert "Revert "Remove ref project from Microsoft.AspNetCore.Testing (#…
4944ae4 
…2817)" (#2882)"

This reverts commit 1286a6f.
@wtgodbe wtgodbe mentioned this pull request Jan 31, 2020
Closed
wtgodbe added a commit that referenced this pull request Feb 4, 2020
@wtgodbe
Revert "Revert "Remove ref project from Microsoft.AspNetCore.Testing (#…
b67ad25 
…2817)" (#2882)"

This reverts commit 1286a6f.
@wtgodbe wtgodbe mentioned this pull request Feb 4, 2020
Merged
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Feb 12, 2020
Remove ref project from Microsoft.AspNetCore.Testing (dotnet/extensio…
cd84e05 
…ns#2817)

\n\nCommit migrated from dotnet/extensions@b624d6b
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Feb 12, 2020
@wtgodbe
Revert "Remove ref project from Microsoft.AspNetCore.Testing (dotnet/…
5f3abb2 
…extensions#2817)" (dotnet/extensions#2882)

This reverts commit dotnet/extensions@b624d6b.\n\nCommit migrated from dotnet/extensions@1286a6f
wtgodbe added a commit that referenced this pull request Feb 13, 2020
@wtgodbe
Revert "Revert "Remove ref project from Microsoft.AspNetCore.Testing (#…
7a077d4 
…2817)" (#2882)" (#2936)

This reverts commit 1286a6f.
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Feb 15, 2020
Remove ref project from Microsoft.AspNetCore.Testing (dotnet/extensio…
9eed437 
…ns#2817)

\n\nCommit migrated from dotnet/extensions@b624d6b
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Feb 15, 2020
@wtgodbe
Revert "Remove ref project from Microsoft.AspNetCore.Testing (dotnet/…
45c582f 
…extensions#2817)" (dotnet/extensions#2882)

This reverts commit dotnet/extensions@b624d6b.\n\nCommit migrated from dotnet/extensions@1286a6f
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Feb 28, 2020
Remove ref project from Microsoft.AspNetCore.Testing (dotnet/extensio…
48a4a96 
…ns#2817)

Commit migrated from dotnet/extensions@b624d6b
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Feb 28, 2020
@wtgodbe
Revert "Remove ref project from Microsoft.AspNetCore.Testing (dotnet/…
c581a60 
…extensions#2817)" (dotnet/extensions#2882)

This reverts commit b624d6ba91b9c292ff9a2aa786a575b0eaa31b4b.


Commit migrated from dotnet/extensions@1286a6f
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Feb 28, 2020
@wtgodbe
Revert "Revert "Remove ref project from Microsoft.AspNetCore.Testing (d…
9c73a5b 
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936)

This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08.


Commit migrated from dotnet/extensions@7a077d4
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 2, 2020
Remove ref project from Microsoft.AspNetCore.Testing (dotnet/extensio…
83990ae 
…ns#2817)

Commit migrated from dotnet/extensions@b624d6b
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 2, 2020
@wtgodbe
Revert "Remove ref project from Microsoft.AspNetCore.Testing (dotnet/…
6cd8c04 
…extensions#2817)" (dotnet/extensions#2882)

This reverts commit b624d6ba91b9c292ff9a2aa786a575b0eaa31b4b.


Commit migrated from dotnet/extensions@1286a6f
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 2, 2020
@wtgodbe
Revert "Revert "Remove ref project from Microsoft.AspNetCore.Testing (d…
81a9181 
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936)

This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08.


Commit migrated from dotnet/extensions@7a077d4
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 11, 2020
Remove ref project from Microsoft.AspNetCore.Testing (dotnet/extensio…
c119c04 
…ns#2817)

Commit migrated from dotnet/extensions@b624d6b
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 11, 2020
@wtgodbe
Revert "Remove ref project from Microsoft.AspNetCore.Testing (dotnet/…
08af899 
…extensions#2817)" (dotnet/extensions#2882)

This reverts commit b624d6ba91b9c292ff9a2aa786a575b0eaa31b4b.


Commit migrated from dotnet/extensions@1286a6f
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 11, 2020
@wtgodbe
Revert "Revert "Remove ref project from Microsoft.AspNetCore.Testing (d…
d33c948 
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936)

This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08.


Commit migrated from dotnet/extensions@7a077d4
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 11, 2020
Remove ref project from Microsoft.AspNetCore.Testing (dotnet/extensio…
9e81e13 
…ns#2817)

Commit migrated from dotnet/extensions@b624d6b
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 11, 2020
@wtgodbe
Revert "Remove ref project from Microsoft.AspNetCore.Testing (dotnet/…
e701e8f 
…extensions#2817)" (dotnet/extensions#2882)

This reverts commit b624d6ba91b9c292ff9a2aa786a575b0eaa31b4b.


Commit migrated from dotnet/extensions@1286a6f
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 11, 2020
@wtgodbe
Revert "Revert "Remove ref project from Microsoft.AspNetCore.Testing (d…
1371739 
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936)

This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08.


Commit migrated from dotnet/extensions@7a077d4
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 25, 2020
Remove ref project from Microsoft.AspNetCore.Testing (dotnet/extensio…
0cc158f 
…ns#2817)

Commit migrated from dotnet/extensions@b624d6b
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 25, 2020
@wtgodbe
Revert "Remove ref project from Microsoft.AspNetCore.Testing (dotnet/…
c95bcf3 
…extensions#2817)" (dotnet/extensions#2882)

This reverts commit b624d6ba91b9c292ff9a2aa786a575b0eaa31b4b.


Commit migrated from dotnet/extensions@1286a6f
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 25, 2020
@wtgodbe
Revert "Revert "Remove ref project from Microsoft.AspNetCore.Testing (d…
63990fc 
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936)

This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08.


Commit migrated from dotnet/extensions@7a077d4
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 27, 2020
Remove ref project from Microsoft.AspNetCore.Testing (dotnet/extensio…
babf4ec 
…ns#2817)

Commit migrated from dotnet/extensions@b624d6b
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 27, 2020
@wtgodbe
Revert "Remove ref project from Microsoft.AspNetCore.Testing (dotnet/…
baa63ca 
…extensions#2817)" (dotnet/extensions#2882)

This reverts commit b624d6ba91b9c292ff9a2aa786a575b0eaa31b4b.


Commit migrated from dotnet/extensions@1286a6f
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 27, 2020
@wtgodbe
Revert "Revert "Remove ref project from Microsoft.AspNetCore.Testing (d…
c3e8373 
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936)

This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08.


Commit migrated from dotnet/extensions@7a077d4
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dougbu dougbu dougbu approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@Tratcher Tratcher Awaiting requested review from Tratcher Tratcher is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JunTaoLuo @Pilchie @dougbu @wtgodbe