Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/3.1] Update dependencies from dotnet/roslyn #2652

Merged

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Build: 20191112.5
  • Date Produced: 11/13/2019 12:26 AM
  • Commit: ff930dec4565e2bc424ad3bf3e22ecb20542c87d
  • Branch: refs/heads/release/dev16.4-vs-deps
  • Updates:
    • Microsoft.Net.Compilers.Toolset -> 3.4.0-beta4-19562-05

…112.5

- Microsoft.Net.Compilers.Toolset - 3.4.0-beta4-19562-05
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 13, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: Extensions-ci, Extensions-ci (Build Test: Linux Source Build), Extensions-ci (Build Ubuntu 16.04 Release), Extensions-ci (Build Ubuntu 16.04 Debug), Extensions-ci (Build OSX Release), Extensions-ci (Build OSX Debug), Extensions-ci (Build Windows Release), Extensions-ci (Build Windows Debug), Extensions-ci (Build Code check)
  • Standard Merge Policies There are reviews that have requested changes.

Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't merge this for GA

@dougbu
Copy link
Member

dougbu commented Nov 13, 2019

@wtgodbe why not merge this for GA? Looks like a very minor version bump and it's coming from the correct '.NET Core 3.1 Release' channel.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 13, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: Extensions-ci, Extensions-ci (Build Test: Linux Source Build), Extensions-ci (Build Ubuntu 16.04 Release), Extensions-ci (Build Ubuntu 16.04 Debug), Extensions-ci (Build OSX Release), Extensions-ci (Build OSX Debug), Extensions-ci (Build Windows Release), Extensions-ci (Build Windows Debug), Extensions-ci (Build Code check)
  • Standard Merge Policies There are reviews that have requested changes.

@wtgodbe
Copy link
Member

wtgodbe commented Nov 13, 2019

@dougbu we have to "cut off" Roslyn flow at some point since the sub is set to everyBuild - I had already marked Extensions stable & didn't want to risk any more delays in GA since the build was already going slowly (and at that point we were in AspNetCore). I held this change & the corresponding one in Toolset since I wasn't aware of Roslyn getting a fix approved by tactics yesterday (for GA).

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 13, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: Extensions-ci, Extensions-ci (Build Test: Linux Source Build), Extensions-ci (Build Ubuntu 16.04 Release), Extensions-ci (Build OSX Release), Extensions-ci (Build Ubuntu 16.04 Debug), Extensions-ci (Build OSX Debug), Extensions-ci (Build Windows Release), Extensions-ci (Build Code check), Extensions-ci (Build Windows Debug)
  • Standard Merge Policies There are reviews that have requested changes.

Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We reset GA, so we can take this

@wtgodbe wtgodbe removed the blocked label Nov 15, 2019
@wtgodbe wtgodbe merged commit 5033889 into release/3.1 Nov 15, 2019
@wtgodbe wtgodbe deleted the darc-release/3.1-95ab06da-440a-4e13-9c8b-96cc74cf9622 branch November 15, 2019 00:52
@dotnet dotnet locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants