Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to publish Goldilocks app for NativeAOT #1783

Open
eerhardt opened this issue Jan 19, 2023 · 3 comments
Open

Add script to publish Goldilocks app for NativeAOT #1783

eerhardt opened this issue Jan 19, 2023 · 3 comments

Comments

@eerhardt
Copy link
Contributor

When new developers want to test out their changes against the "Stage 1" Goldilocks app, they have to know exactly how to publish the app (PublishAot=true, TrimMode=full, StripSymbols=true, etc).

We should have a script next to the .csproj that devs can easily run locally to get the same app that is used in our benchmarks.

Note this could also be documentation, but a script feels nicer.

cc @mitchdenny @eiriktsarpalis

@sebastienros
Copy link
Member

We have the README in the scenarios folder that references all the available benchmarks and sample command lines for each. Can you check if it should be documented there too?

@sebastienros
Copy link
Member

@mitchdenny mitchdenny self-assigned this Jan 19, 2023
@eerhardt
Copy link
Contributor Author

@eiriktsarpalis and I chatted a bit about this.

Our thinking is that it would be best if we had the ability to point to a local build of dotnet/runtime and/or dotnet/aspnetcore. That way runtime and aspnet devs could easily test their changes changes by doing something like:

crank
  --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/goldilocks.benchmarks.yml
  --scenario stage1publishaot
  --profile aspnet-perf-win
  --chart
  --application.runtimePackage C:\git\runtime\artifacts\packages\Release\Shipping\runtime.win-x64.Microsoft.DotNet.ILCompiler.8.0.0-dev.nupkg

And crank would upload and use the runtime.win-x64.Microsoft.DotNet.ILCompiler.8.0.0-dev.nupkg that I locally built.

The same functionality for --[JOB].aspNetCorePackage.

Then we could just have a README that said:

  1. Build your changes locally using ./build.cmd clr.aot+libs+packs -c release
  2. Run the above crank command

@mitchdenny mitchdenny removed their assignment Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants