Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newtonsoft.Json in Microsoft.Owin.Security.OpenIdConnect 4.2.1+ #478

Closed
LeaFrock opened this issue Sep 19, 2022 · 3 comments
Closed

Newtonsoft.Json in Microsoft.Owin.Security.OpenIdConnect 4.2.1+ #478

LeaFrock opened this issue Sep 19, 2022 · 3 comments
Assignees

Comments

@LeaFrock
Copy link

I notice that Newtonsoft.Json is imported into Microsoft.Owin.Security.OpenIdConnect at the beginning of 4.2.1, by the commit #445 .

But it seems not necessary in the lib (which not exists <= 4.2.0). Would it be a mistake?

@Tratcher
Copy link
Member

@Tratcher Tratcher self-assigned this Sep 19, 2022
@Tratcher
Copy link
Member

Oh, System.IdentityModel.Tokens.Jwt 5.3 pulled in Newtonsoft.Json transitively, so it was required, it just didn't need to be listed in the top level nuspec/nupkg.
https://www.nuget.org/packages/System.IdentityModel.Tokens.Jwt/5.3.0#dependencies-body-tab

@LeaFrock
Copy link
Author

LeaFrock commented Sep 20, 2022

it just didn't need to be listed in the top level nuspec/nupkg.

Ah, got it. Thanks!

The reason of this issue is that, the Nuget manager shows a security warning of Newtonsoft.Json after I upgrade Microsoft.Owin.Security.* packages. As the nupkg lists Newtonsoft.Json 10.0.3(which not show in list before) and that version has been outdated, I feel confused. Now I've upgraded Newtonsoft.Json to 13.0.1 to fix the warnning.

@aspnet aspnet locked as resolved and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants