Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Routing to use ProjectReference and move into src/Http folder #4441

Merged
merged 2 commits into from
Dec 6, 2018

Conversation

natemcmaster
Copy link
Contributor

This implements #4246 for projects that were under src/Routing.

Changes:

  • Stop producing Microsoft.AspNetCore.Routing.DecisionTree.Sources. I could not find any usages of outside of the Microsoft.AspNetCore.Routing assembly, so I've moved this to be a subfolder of code in the Microsoft.AspNetCore.Routing project.
  • Stop building src/Routing as a submodule. Use ProjectReference instead
  • Move projects from src/Routing into src/Http/Routing/ and src/Http/Routing.Abstractions/
  • Update package baselines and dependencies to support building routing projects and samples

@natemcmaster
Copy link
Contributor Author

Two test failures in HttpSys: FYI @jkotalik @muratg

  • Microsoft.AspNetCore.Server.HttpSys.FunctionalTests.Microsoft.AspNetCore.Server.HttpSys.Listener.ResponseCachingTests.Caching_SendFileWithFullContentLength_Cached
  • Microsoft.AspNetCore.Server.HttpSys.FunctionalTests.Microsoft.AspNetCore.Server.HttpSys.ServerTests.Server_MultipleStopAsyncCallsWaitForRequestsToDrain_Success

These appear to be unrelated to Routing.

@Tratcher Tratcher requested a review from rynowak December 5, 2018 22:06
@Tratcher
Copy link
Member

Tratcher commented Dec 5, 2018

I'm torn between putting this in Http vs Middleware. @JamesNK @rynowak?

@JamesNK
Copy link
Member

JamesNK commented Dec 5, 2018

While routing has middleware, its job to match an HTTP request to an endpoint does feel more fundamental than other middleware. Plus routing has link generation, and that isn't middleware specific. I prefer Http.

@natemcmaster
Copy link
Contributor Author

If there are no more objections, I'd like to merge this later today.

@natemcmaster natemcmaster merged commit 50bea05 into dotnet:release/2.1 Dec 6, 2018
@natemcmaster natemcmaster deleted the routing-2.1 branch December 6, 2018 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants