Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/2.1] React to deletion of DockerHub image #34315

Merged
merged 2 commits into from Jul 15, 2021

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Jul 13, 2021

  • had been deprecated for a while

- had been deprecated for a while
@dougbu dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 13, 2021
@dougbu dougbu requested a review from a team July 13, 2021 19:43
@msftbot msftbot bot added this to PR Open in Servicing Status Jul 13, 2021
@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label Jul 13, 2021
@msftbot msftbot bot moved this from PR Open to Tell Mode in Servicing Status Jul 13, 2021
@dougbu
Copy link
Member Author

dougbu commented Jul 13, 2021

If we need this, will be a tell-mode change. But, branches aren't currently open and fix will need to be included in next branding update rather than separate. Just making sure the rest of the infrastructure is working…

- mainly important in SignalR project

nit: Accept minor / patch updates `npm install` brought in
@dougbu
Copy link
Member Author

dougbu commented Jul 13, 2021

Selenium driver was out-of-date in src\SignalR\clients\ts\webdriver-tap-runner\package.json. I fixed that up in added commit.

@BrennanConroy npm audit shows only two low severity issues remain in that project. They were excluded because they apparently contain breaking changes. See

Do we need either update in release/2.1❔

On the other hand, any concerns about the upgrades in the package-lock.json file for that project❔

@BrennanConroy
Copy link
Member

Test code, update looks fine. I assume the audit issues were for the test project?

@dougbu
Copy link
Member Author

dougbu commented Jul 13, 2021

I assume the audit issues were for the test project?

I only ran npm audit in the webdriver-tap-runner folder. Is the entire project test code❔

@BrennanConroy
Copy link
Member

The /signalr and /signalr-protocol-msgpack folders are non-test code

@dougbu
Copy link
Member Author

dougbu commented Jul 14, 2021

The /signalr and /signalr-protocol-msgpack folders are non-test code

Are you asking me to run npm audit in those folders❔ Or, did you leave only out of your comment 😀

@BrennanConroy
Copy link
Member

Don't do anything else here, we're removing/not-shipping the signalr npm bits for 2.1 after August 21st this year.

@dougbu
Copy link
Member Author

dougbu commented Jul 15, 2021

@vseanreesermsft @wtgodbe we're open for 2.1.x business i.e. I can merge this, correct❔

@wtgodbe wtgodbe merged commit ff52441 into release/2.1 Jul 15, 2021
@wtgodbe wtgodbe deleted the dougbu/mcr.migration branch July 15, 2021 18:14
@msftbot msftbot bot moved this from Tell Mode to Merged in Servicing Status Jul 15, 2021
@dougbu dougbu added this to the 2.1.29 milestone Sep 14, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
No open projects
Servicing Status
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

3 participants