Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update branding to 2.1.22 #24826

Merged
merged 5 commits into from
Aug 12, 2020
Merged

Update branding to 2.1.22 #24826

merged 5 commits into from
Aug 12, 2020

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Aug 12, 2020

No description provided.

Tratcher and others added 3 commits July 16, 2020 21:30
There are two places in 2.1 where SendFileAsync falls back to a copy loop. These loops should short circuit when the client disconnects, or else the server will sit there and burn resources reading the whole file from disk.

Fix: If you passed in your own active CT we'll use it. Otherwise we'll use the RequestAborted token.
@dougbu dougbu requested a review from a team August 12, 2020 04:21
@ghost ghost added this to PR Open in Servicing Status Aug 12, 2020
@dougbu dougbu added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode labels Aug 12, 2020
@ghost ghost moved this from PR Open to Tell Mode in Servicing Status Aug 12, 2020
@dougbu dougbu changed the title Dougbu/update.branding.2.1 Update branding to 2.1.22 Aug 12, 2020
@dougbu dougbu merged commit 0a0e1ad into release/2.1 Aug 12, 2020
@dougbu dougbu deleted the dougbu/update.branding.2.1 branch August 12, 2020 18:43
@ghost ghost moved this from Tell Mode to Merged in Servicing Status Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
No open projects
Servicing Status
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants