Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Azure Artifacts instead of MyGet #23929

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Use Azure Artifacts instead of MyGet #23929

merged 1 commit into from
Jul 28, 2020

Conversation

garath
Copy link
Member

@garath garath commented Jul 14, 2020

As part of moving to Azure Artifacts from MyGet, point all MyGet feed sources to new Azure Artifacts feed.

@dougbu FYI, from email.

@ghost ghost added this to PR Open in Servicing Status Jul 14, 2020
dougbu
dougbu approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering a bit whether some of the "added" feeds in a few directories can be removed. But, that's fairly minor and I'm not sure where we block use of the usual build/sources.props file.

@jaredpar jaredpar mentioned this pull request Jul 14, 2020
Closed
@Pilchie Pilchie added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode labels Jul 15, 2020
@ghost ghost moved this from PR Open to Tell Mode in Servicing Status Jul 16, 2020
@markwilkie
Copy link
Member

Thanks for approving @dougbu. Would you mind merging please? We don't have permission...

@dougbu
Copy link
Member

dougbu commented Jul 27, 2020

Build in a weird state. Setting auto-merge and will start the validation build from scratch.

@dougbu
Copy link
Member

dougbu commented Jul 27, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@ghost
Copy link

ghost commented Jul 27, 2020

Hello @dougbu!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Jul 27, 2020

Apologies, while this PR appears ready to be merged, it looks like release/2.1 is a protected branch and I have not been granted permission to perform the merge.

@dougbu
Copy link
Member

dougbu commented Jul 27, 2020

Ah well, I'll come back and do the final merge

@dougbu dougbu merged commit 94076d4 into dotnet:release/2.1 Jul 28, 2020
@ghost ghost moved this from Tell Mode to Merged in Servicing Status Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
No open projects
Servicing Status
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garath @markwilkie @dougbu @Pilchie