Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.1] Enable control flow guard for IIS dlls #22608

Merged
merged 1 commit into from
Jun 11, 2020
Merged

[2.1] Enable control flow guard for IIS dlls #22608

merged 1 commit into from
Jun 11, 2020

Conversation

jkotalik
Copy link
Contributor

@jkotalik jkotalik commented Jun 6, 2020

Backporting #22480 to 2.1.

I'm not certain if this should be ask mode or tell mode for this change. @blowdart @Pilchie

@ghost ghost added the area-servers label Jun 6, 2020
@ghost ghost added this to PR Open in Servicing Status Jun 6, 2020
@jkotalik jkotalik added the tell-mode Indicates a PR which is being merged during tell-mode label Jun 8, 2020
@ghost ghost moved this from PR Open to Tell Mode in Servicing Status Jun 8, 2020
@dougbu dougbu mentioned this pull request Jun 9, 2020
Merged
@Pilchie Pilchie added * NO MERGE * Do not merge this PR as long as this label is present. Servicing-approved Shiproom has approved the issue labels Jun 9, 2020
@Pilchie
Copy link
Member

Pilchie commented Jun 9, 2020

This is approved for July servicing, but the branch isn't open yet.

@Pilchie Pilchie added this to the 2.1.20 milestone Jun 9, 2020
@jkotalik
Copy link
Contributor Author

@dotnet/aspnet-build please merge 😄

@wtgodbe wtgodbe merged commit d4f43e7 into release/2.1 Jun 11, 2020
@wtgodbe wtgodbe deleted the jkotalik/21cfg branch June 11, 2020 17:20
@ghost ghost moved this from Tell Mode to Merged in Servicing Status Jun 11, 2020
@wtgodbe wtgodbe removed the * NO MERGE * Do not merge this PR as long as this label is present. label Jun 11, 2020
@BrennanConroy
Copy link
Member

Do we need to add this to the patch config?

@jkotalik
Copy link
Contributor Author

No, these changes only affect the ANCM msis and aren't part of any packages.

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Servicing-approved Shiproom has approved the issue tell-mode Indicates a PR which is being merged during tell-mode
Projects
No open projects
Servicing Status
  
Merged
Milestone
2.1.20
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jkotalik @Pilchie @BrennanConroy @dougbu @amcasey @wtgodbe