Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always include ANCM in build output #11199

Merged
merged 2 commits into from Jun 14, 2019

Conversation

jkotalik
Copy link
Contributor

Note, this is purely a build only change. I'm currently working on verifying this works with separate branches on aspnetci.

Same change as #11198, except just for 2.1.

@jkotalik jkotalik requested review from analogrelay and a team June 14, 2019 01:30
Copy link
Contributor

@JunTaoLuo JunTaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anurse Similarly, 2.1 patching needs this fix as well.

@analogrelay
Copy link
Contributor

Ok by me. Since this is build only, please email netcoreship with the information (for both PRs).

If this is necessary to build the July patch, go ahead. Otherwise, hold until shiproom (via email) confirms it can be merged. We're trying to get the final build by end-of-week. I did see some emails going around about this though and I'm still catching up so if I'm behind a bit, I trust you to do the needful in conversations with shiproom ;P.

@jkotalik
Copy link
Contributor Author

If this is necessary to build the July patch, go ahead.

Yep this is necessary 😄

@vivmishra vivmishra added the Servicing-approved Shiproom has approved the issue label Jun 14, 2019
@vivmishra vivmishra modified the milestones: 3.0.0-preview7, 2.1.12 Jun 14, 2019
@vivmishra
Copy link

Approved for 2.1.12

@JunTaoLuo JunTaoLuo merged commit f74ca43 into release/2.1 Jun 14, 2019
@ghost ghost deleted the jkotalik/fixAncmPackageVersions branch June 14, 2019 20:29
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants