Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always include ANCM in build output #11198

Merged
merged 2 commits into from Jun 14, 2019

Conversation

jkotalik
Copy link
Contributor

@jkotalik jkotalik commented Jun 14, 2019

Note, this is purely a build only change. I'm currently working on verifying this works with separate branches on aspnetci.

Impact

After we stopped pushing to MyGet, ANCM transfer packages have stopped being uploaded. Builds are now failing with an error saying ANCM could not be found as an artifact dependency as well as the latest version of ANCM being 2.2.2 on myget. This change makes it so ANCM always builds, regardless of if there was a change to ANCM or not.

The reason this is fine is:

  • ANCM is shipped globally and isn't put in a package.
  • We are already doing this in 3.0.

Risk

Very low risk. We are rebuilding ANCM every patch version, which will update dll/msi versions. However, the source code being used is the same.

Copy link
Contributor

@JunTaoLuo JunTaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is a fix that we need in order to build our 2.2 patch. @anurse what kind of approval process is needed for this change?

@analogrelay
Copy link
Contributor

Yes this is a fix that we need in order to build our 2.2 patch.

👍 . Make sure netcoreship is aware of the change, but if it's necessary to build, we gotta take it so go ahead.

@jkotalik
Copy link
Contributor Author

@vivmishra vivmishra added the Servicing-approved Shiproom has approved the issue label Jun 14, 2019
@vivmishra vivmishra added this to the 2.2.6 milestone Jun 14, 2019
@vivmishra
Copy link

Approved for 2.2.6

@JunTaoLuo
Copy link
Contributor

I'm going to merge this one since we are running into build hangs on 2.2 right now and it's unlikely that the tests will pass. The linux failure is unrelated.

@JunTaoLuo JunTaoLuo merged commit 0460bc3 into release/2.2 Jun 14, 2019
@ghost ghost deleted the jkotalik/alwaysIncludeANCMInBuildOutput branch June 14, 2019 19:50
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants