Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change]: Event IDs for some Microsoft.AspNetCore.Mvc.Core log messages changed #483

Open
1 of 2 tasks
pranavkm opened this issue Mar 1, 2022 · 0 comments
Open
1 of 2 tasks
Labels
7.0.0 Breaking change Documented The breaking change has been published to the .NET Core docs

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Mar 1, 2022

Description

As part of updating the Microsoft.AspNetcore.Mvc.Core assembly to use LoggerMessageAttribute, we discovered logger event Ids being reused within a single log category. Log IDs and names should be unique so different message types can be identified. Consequently, these have been updated to ensure that the event Ids are unique for a logger category.

Version

.NET 7

Previous behavior

Some logger event IDs in Microsoft.AspNetCore.Mvc.Core were re-used within a single category.

New behavior

Duplicated event ids within a single category within the Microsoft.AspNetCore.Mvc.Core assembly were updated.

Type of breaking change

  • Binary incompatible: Existing binaries may encounter a breaking change in behavior, such as failure to load/execute or different run-time behavior.
  • Source incompatible: Source code may encounter a breaking change in behavior when targeting the new runtime/component/SDK, such as compile errors or different run-time behavior.

Reason for change

Log IDs and names should be unique so different message types can be identified.

Recommended action

If you have code or configuration that references the old IDs, update those references to use the new IDs.

Affected APIs

Not detectable via API analysis

@aspnet aspnet locked and limited conversation to collaborators Mar 1, 2022
@serpent5 serpent5 added the 7.0.0 label Mar 9, 2022
@serpent5 serpent5 added the Documented The breaking change has been published to the .NET Core docs label Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
7.0.0 Breaking change Documented The breaking change has been published to the .NET Core docs
Projects
None yet
Development

No branches or pull requests

2 participants