Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support axios@1.x #788

Closed
su8ru opened this issue Dec 15, 2022 · 2 comments
Closed

Support axios@1.x #788

su8ru opened this issue Dec 15, 2022 · 2 comments

Comments

@su8ru
Copy link
Collaborator

su8ru commented Dec 15, 2022

Description

axios 1.x 系で @aspida/axios を使用すると

throw new AxiosError('options must be an object', AxiosError.ERR_BAD_OPTION_VALUE);

のようなエラーが生じます。

Repro: https://stackblitz.com/edit/aspida-axios-1-x?file=index.ts&view=editor

Describe alternatives you've considered

peerDependencies があれば warning が出てくれるのですが…(関連: #776

Additional context

詳細は追いきれていませんが、paramsSerializer の指定方法が変わっているようです。

@pipboy3000
Copy link

axios v1.3.5でparamsSerializerが関数を受け取るようになった( axios/axios@a56c866) ので、エラーは解消したと思います。

@solufa
Copy link
Member

solufa commented Aug 3, 2023

v1.13.0からaxios v1でテストを実施するようにしました

@solufa solufa closed this as completed Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants