Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Script doesn't check if user has gsed installed #121

Closed
Aghassi opened this issue Dec 5, 2022 · 1 comment
Closed

[BUG]: Script doesn't check if user has gsed installed #121

Aghassi opened this issue Dec 5, 2022 · 1 comment
Assignees
@gregmagolan

Comments

@Aghassi
Copy link

Aghassi commented Dec 5, 2022

rules_swc/scripts/mirror_releases.sh

Line 25 in d3cdeca

Darwin*) gsed "$@" ;;

This is a super minor one, but this script will fail if the user doesn't have gsed installed. Consider adding a check and failing fast with install instructions.
@alexeagle
Copy link
Member

#57 removed the use of sed / gsed from the mirror script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregmagolan gregmagolan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexeagle @gregmagolan @Aghassi