Update typing rewrite with special cases #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Jul 18, 2022
asottile
reviewed
Jul 19, 2022
testing/generate-typing-rewrite-info
Outdated
Comment on lines
20
to
29
| CUSTOM_TYPING_EXT_SYMBOLS = { | ||
| (3, 11): {'NamedTuple', 'TypedDict'}, | ||
| } |
There was a problem hiding this comment.
ah oh I mean I would keep the data here but just delete the 3.11 stuff from the output when copying it over (that way when 3.11 final comes out I can just rerun this)
* 3.10: get_origin, get_args * 3.11: NamedTuple, TypedDict, final, overload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: asottile/pyupgrade#683
The typing_extensions readme lists a couple of special cases of objects which are available in older Python versions but don't provide the full support of new features.