rewrite to datetime.UTC #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Dec 2, 2022
Comment on lines
27
to
28
| isinstance(parent, ast.Attribute) and | ||
| parent.attr == 'utc' |
There was a problem hiding this comment.
parent should be avoided when possible -- this should start from the datetime Attribute
There was a problem hiding this comment.
I've just pushed a new version without parent. Did I get it right?
There was a problem hiding this comment.
datetime is not an attribute, but a Name.
asottile
reviewed
Dec 2, 2022
Comment on lines
9
to
41
| @pytest.mark.parametrize( | ||
| ('s', 'expected'), | ||
| ( | ||
| pytest.param( | ||
| 'import datetime\n' | ||
| 'print(datetime.timezone.utc)', | ||
|
|
||
| 'import datetime\n' | ||
| 'print(datetime.UTC)', | ||
|
|
||
| id='rewriting to alias', | ||
| ), | ||
| pytest.param( | ||
| 'import datetime\n' | ||
| 'print(datetime.timezone(-1))', | ||
|
|
||
| 'import datetime\n' | ||
| 'print(datetime.timezone(-1))', | ||
|
|
||
| id='not rewriting timezone object to alias', | ||
| ), | ||
| ), | ||
| ) | ||
| def test_fix_datetime_utc_alias(s, expected): | ||
| assert _fix_plugins(s, settings=Settings(min_version=(3,))) == s | ||
| assert _fix_plugins(s, settings=Settings(min_version=(3, 11))) == expected |
There was a problem hiding this comment.
there should be clearly separate noop and non-noop tests -- please follow one of the other tests as an example
Rewrite: ```python import datetime datetime.timezone.utc ``` to alias: ```python import datetime datetime.UTC ``` in Python >= 3.11. Fixes: #755
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite:
to alias:
in Python >= 3.11.
Fixes: #755