Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override default values for boolean flags #51

Closed
amotl opened this issue Oct 22, 2021 · 3 comments
Closed

Override default values for boolean flags #51

amotl opened this issue Oct 22, 2021 · 3 comments

Comments

@amotl
Copy link

amotl commented Oct 22, 2021

Dear Anthony,

while working on wireviz/wireviz-web#1, we believe we just discovered a minor flaw when trying to override the default values for the boolean flags show_missing and skip_covered. Is it possible that I am not able to toggle
skip_covered = false, where its default is True [1]?

[tool.coverage.run]
plugins = ["covdefaults"]

[tool.coverage.report]
fail_under = 90
show_missing = true
skip_covered = false

With kind regards,
Andreas.

[1] https://github.com/asottile/covdefaults/blob/v2.0.0/covdefaults.py#L30-L35

@asottile
Copy link
Owner

it is not possible to do that, intentionally

@asottile
Copy link
Owner

the overridable options are listed in the README

@amotl
Copy link
Author

amotl commented Oct 22, 2021

Hi again,

I just discovered that we had this discussion at #16 already, which I completely forgot about. Apologies!

With kind regards,
Andreas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants