Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

writev_at_eio test hangs with latest Tokio #27

Closed
asomers opened this issue Nov 21, 2021 · 0 comments · Fixed by #28
Closed

writev_at_eio test hangs with latest Tokio #27

asomers opened this issue Nov 21, 2021 · 0 comments · Fixed by #28
Assignees
@asomers

Comments

@asomers
Copy link
Owner

asomers commented Nov 21, 2021

The writev_at_eio test hangs when using the lastest Tokio. I haven't root-caused the problem yet, but the offending PR is tokio-rs/tokio#4157 .
@asomers asomers self-assigned this Nov 21, 2021
@asomers asomers mentioned this issue Nov 21, 2021
Closed
asomers added a commit that referenced this issue Nov 22, 2021
@asomers
Fix lio_listio resubmission with Tokio 1.13.0 and later
200c742 
According to @Darksonn there have never been a guarantee that a future
will get poll()'d a second time if you do not call poll_ready() a second
time after it previously returned Poll::Ready.  But due to a bug in
Tokio 1.12.0 and earlier we got away with it.  Fix it the right way, and
update the Tokio dependency now that the PollAio stuff is merged.

Fixes #27
asomers added a commit that referenced this issue Nov 22, 2021
@asomers
Fix lio_listio resubmission with Tokio 1.13.0 and later
b632a1c 
According to @Darksonn there have never been a guarantee that a future
will get poll()'d a second time if you do not call poll_ready() a second
time after it previously returned Poll::Ready.  But due to a bug in
Tokio 1.12.0 and earlier we got away with it.  Fix it the right way, and
update the Tokio dependency now that the PollAio stuff is merged.

Fixes #27
@asomers asomers mentioned this issue Nov 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asomers asomers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix lio_listio resubmission with Tokio 1.13.0 and later asomers/tokio-file
1 participant
@asomers