Add support for UTF-32 #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er versions of Node.
ashtuchkin
reviewed
Jun 25, 2019
|
I've made pretty much all of the changes you've suggested (I'm not sure if the all-codepoint unit tests are exactly what you had in mind), but now there are problems with compatibility with older versions of Node to try to figure out. One of them looks serious, " offset is not uint" on the use of "Buffer.readUInt32BE". |
|
Problems with older versions of Node sorted out. |
ashtuchkin
reviewed
Jun 26, 2019
|
Awesome, thank you Kerry! I'll cut a new version and upload it to npm soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for UTF-32 (also using the alias UCS-4), both little-endian and big-endian. UTF32-LE and UTF32-BE can be selected specifically, or a general UTF-32 codec with BOM-based and content-based automatic detection can be used.