Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

danger-swiftlint lints files from merge commits, and not just my changes #86

Open
72A12F4E opened this issue Feb 7, 2018 · 1 comment

Comments

@72A12F4E
Copy link

72A12F4E commented Feb 7, 2018

I noticed that when I have a merge commit in my history, danger-swiftlint will output lint violations that occur in the merges, and not my changes. This causes confusion.

@72A12F4E 72A12F4E changed the title danger-swiftlint lints files from merge commits, and not just changes danger-swiftlint lints files from merge commits, and not just my changes Feb 7, 2018
@ashfurrow
Copy link
Owner

Sure, so I want to make sure I understand the issue. A PR's commit history would like like:

abcdef My first commit
deadee Merge commit from master
cafeba My second commit

And this plugin is listing the files changed in that middle commit? That's going to be tricky since we get the list of changed files from Danger, who in turn gets the data from loading git for the repo directory and calculating the diff based on PR target and base branches. Maybe it's possible to filter out merge commits from this diff, and then use the files from there?

I don't have a tonne of time to work on this, so if anyone else is available, help would be welcome 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants