You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that when I have a merge commit in my history, danger-swiftlint will output lint violations that occur in the merges, and not my changes. This causes confusion.
The text was updated successfully, but these errors were encountered:
72A12F4E
changed the title
danger-swiftlint lints files from merge commits, and not just changes
danger-swiftlint lints files from merge commits, and not just my changes
Feb 7, 2018
Sure, so I want to make sure I understand the issue. A PR's commit history would like like:
abcdef My first commit
deadee Merge commit from master
cafeba My second commit
And this plugin is listing the files changed in that middle commit? That's going to be tricky since we get the list of changed files from Danger, who in turn gets the data from loading git for the repo directory and calculating the diff based on PR target and base branches. Maybe it's possible to filter out merge commits from this diff, and then use the files from there?
I don't have a tonne of time to work on this, so if anyone else is available, help would be welcome 🙇
I noticed that when I have a merge commit in my history, danger-swiftlint will output lint violations that occur in the merges, and not my changes. This causes confusion.
The text was updated successfully, but these errors were encountered: