Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds fail_on_warning flag #109

Closed
wants to merge 4 commits into from
Closed

Adds fail_on_warning flag #109

wants to merge 4 commits into from

Conversation

d-a-n
Copy link

@d-a-n d-a-n commented Sep 6, 2018

fixes #78

@ashfurrowbot
Copy link

ashfurrowbot commented Sep 6, 2018 •
edited

Rubocop violations

File Line Reason
lib/danger_plugin.rb 22 Class has too many lines. [144/140]
lib/danger_plugin.rb 122 Use a guard clause instead of wrapping the code inside a conditional expression.
lib/danger_plugin.rb 134 Trailing whitespace detected.

Generated by 🚫 Danger

@ashfurrow-peril
Copy link

ashfurrow-peril bot commented Sep 6, 2018 •
edited

Danger run resulted in 2 warnings; to find out more, see the checks page.

Generated by 🚫 dangerJS

@d-a-n d-a-n closed this Sep 6, 2018
@ashfurrow
Copy link
Owner

Hi there – any thing I can do to help get this merged?

@ashfurrow ashfurrow mentioned this pull request Mar 13, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Fail on warnings
3 participants
@d-a-n @ashfurrowbot @ashfurrow