Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop testify dependency #10

Merged
merged 2 commits into from Feb 23, 2022
Merged

drop testify dependency #10

merged 2 commits into from Feb 23, 2022

Conversation

kruskall
Copy link
Contributor

makezero is only using assert.ElementsMatch once which can be easily replaced with reflect.DeepEqual

@ashanbrown
Copy link
Owner

Seems reasonable given how little we use testify (as much as I do like it). I created https://github.com/kruskall/makezero/pull/1 to update your branch with master, to include some other changes I made. Happy to merge this if that looks ok.

@ashanbrown
Copy link
Owner

I am curious to know what problem including testify was causing for you. testify was only used in a test, so I don't expect it to be vendored in recent versions of go, for example. Was it causing some sort of version conflict?

@kruskall
Copy link
Contributor Author

kruskall commented Feb 22, 2022

Seems reasonable given how little we use testify (as much as I do like it). I created https://github.com/kruskall/makezero/pull/1 to update your branch with master, to include some other changes I made. Happy to merge this if that looks ok.

@ashanbrown I've rebased on the main branch and fixed the merge conflicts. You should be able to merge this now.


I am curious to know what problem including testify was causing for you. testify was only used in a test, so I don't expect it to be vendored in recent versions of go, for example. Was it causing some sort of version conflict?

golang/go#41431

@ashanbrown ashanbrown merged commit f3a1f1c into ashanbrown:master Feb 23, 2022
@kruskall kruskall deleted the drop/testify branch February 27, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants