Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Gems file final empty line #335

Open
jmschp opened this issue Feb 22, 2023 · 2 comments
Open

Default Gems file final empty line #335

jmschp opened this issue Feb 22, 2023 · 2 comments

Comments

@jmschp
Copy link

jmschp commented Feb 22, 2023

Installing defaults gems skips last gem if no final empty line

Versions:

  • MacBook Pro (Retina, 13-inch, Early 2015) (also tested in Apple M1)
  • macOS Monterey 12.6.3 (21G419)
  • asdf v0.11.1

When installing any ruby version, when it comes to install the default gems, if the file does not have a final empty line, the last gem in the list will not be installed.

@SeanSith
Copy link
Contributor

Not speaking for the maintainer, but it's generally considered bad practice to not finish a text file with a newline in Unix system. Many other utilities fail to process "correctly" when their inputs lack a newline.

@jmschp
Copy link
Author

jmschp commented Mar 31, 2023

@SeanSith

I agree, but shit happens some time and we might miss a final empty line.

Maybe, this could be just a warning on the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants