Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASDF appears to be broken by latest release of pyyaml #659

Closed
drdavella opened this issue Mar 14, 2019 · 3 comments · Fixed by #662
Closed

ASDF appears to be broken by latest release of pyyaml #659

drdavella opened this issue Mar 14, 2019 · 3 comments · Fixed by #662

Comments

@drdavella
Copy link
Contributor

drdavella commented Mar 14, 2019 •
edited

The pyyaml package jumped from 3.13 (released in July 2018) to 5.1 (released on March 13, 2019). This has caused some test failures in ASDF, which mostly appear to be related to inline arrays. See this cron job for example failures.
@drdavella
Copy link
Contributor Author

Best current guess is that this is related to yaml/pyyaml#256.

@jdavies-st
Copy link
Contributor

Wow, that's a pretty big jump! Looks like they did a bunch of pre-releases for version 4.0.

https://pypi.org/project/PyYAML/#history

@pllim pllim mentioned this issue Mar 14, 2019
Closed
@drdavella
Copy link
Contributor Author

@jdavies-st yes, and we currently aren't testing against prereleases (see #660).

@drdavella drdavella mentioned this issue Mar 15, 2019
Merged
@asdf-format asdf-format deleted a comment from stscijgbot Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to fix test failures caused by update to pyyaml-5.1 drdavella/asdf
2 participants
@drdavella @jdavies-st