Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deadlock in tests #103

Closed
ascopes opened this issue Oct 18, 2022 · 5 comments · Fixed by #146
Closed

Deadlock in tests #103

ascopes opened this issue Oct 18, 2022 · 5 comments · Fixed by #146
Assignees
@ascopes
Labels
bug Something isn't working testing Improvements to test packs

Comments

@ascopes
Copy link
Owner

ascopes commented Oct 18, 2022 •
edited

Seems to be a deadlock in the tests somewhere.

Identify it and fix it.
@ascopes ascopes added bug Something isn't working testing Improvements to test packs labels Oct 18, 2022
@ascopes ascopes added this to the 1.0.0 milestone Oct 18, 2022
@ascopes ascopes self-assigned this Oct 18, 2022
@ascopes
Copy link
Owner Author

ascopes commented Oct 18, 2022

Seems on Mockito 4.8.1 and Java 19 (Coretto) that this is consistently reproducible now.

./mvnw -pl java-compiler-testing test -T32C -Dsurefire.parallel.forcedTimeout=10 -Dsurefire.parallel.timeout=10 -Dparallel=classesAndMethods -Dsurefire.timeout=10 --debug -DargLine="-Dorg.slf4j.simpleLogger.log=INFO -Dorg.slf4j.simpleLogger.log.io.github.ascopes.jct=DEBUG -Xshare:off -XX:+FlightRecorder -XX:StartFlightRecording=duration=200s,filename=flight.jfr"

Opened up mockito/mockito#2767 in response to this.

@ascopes ascopes changed the title Occasional deadlock in tests Deadlock in tests when running with high concurrency Oct 18, 2022
@ascopes
Copy link
Owner Author

ascopes commented Oct 18, 2022

Seems to be occurring under -T1C, so this is not a concurrency issue.

@ascopes ascopes changed the title Deadlock in tests when running with high concurrency Deadlock in tests Oct 18, 2022
@ascopes
Copy link
Owner Author

ascopes commented Oct 18, 2022

Appears to be impacting Java 19 at the moment.

ascopes added a commit that referenced this issue Oct 23, 2022
@ascopes
Reduce test concurrency to work around #103
abb90d6
@ascopes
Copy link
Owner Author

ascopes commented Nov 5, 2022 •
edited

Looks like mockito/mockito#2780 fixes this, after testing locally.

@ascopes
Copy link
Owner Author

ascopes commented Nov 13, 2022

Changes have been merged into Mockito's main branch. Now just waiting for a new release and this should be able to be closed.

@ascopes ascopes removed this from the 1.0.0 milestone Nov 13, 2022
@ascopes ascopes linked a pull request Nov 14, 2022 that will close this issue
Bump mockito-bom from 4.8.1 to 4.9.0 #146
Merged
@dependabot dependabot bot closed this as completed in #146 Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ascopes ascopes

Labels
bug Something isn't working testing Improvements to test packs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump mockito-bom from 4.8.1 to 4.9.0 ascopes/java-compiler-testing
1 participant
@ascopes