Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add explicit dependency after Gradle complained #1076

Conversation

ahus1
Copy link
Contributor

@ahus1 ahus1 commented Jan 7, 2022

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

  • Bug fix
  • New non-breaking feature
  • New breaking feature
  • Documentation update
  • Build improvement

Description

What is the goal of this pull request?
There is a warning in the build:

2022-01-07T17:47:08.9908240Z > Task :asciidoctorj-wildfly-integration-test:unpackWildfly
2022-01-07T17:47:08.9910154Z Execution optimizations have been disabled for task ':asciidoctorj-wildfly-integration-test:unpackWildfly' to ensure correctness due to the following reasons:
2022-01-07T17:47:08.9914578Z - Gradle detected a problem with the following location: '/home/runner/work/asciidoctorj/asciidoctorj/asciidoctorj-wildfly-integration-test/build'. Reason: Task ':asciidoctorj-wildfly-integration-test:compileTestJava' uses this output of task ':asciidoctorj-wildfly-integration-test:unpackWildfly' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.2/userguide/validation_problems.html#implicit_dependency for more details about this problem.
2022-01-07T17:47:42.7169565Z

How does it achieve that?
Adding the dependency explicitly that Gradle complained about.

Are there any alternative ways to implement this?
(?)

Are there any implications of this pull request? Anything a user must know?
no

Release notes

(not updated as not relevant to release notes IMHO)

@robertpanzer
Copy link
Member

Thank you!

@robertpanzer robertpanzer merged commit d912aa3 into asciidoctor:main Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants