Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to asciidoctor 2.0.17 #1074

Merged

Conversation

robertpanzer
Copy link
Member

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

  • Bug fix
  • New non-breaking feature
  • New breaking feature
  • Documentation update
  • Build improvement

Description

This PR upgrades Asciidoctor to the latest and greatest version 2.0.17.
I also updated JRuby to 9.2.20.1.
I tried to upgrade it to 9.3, however the build failed with OOM errors in org.jruby.util.ByteList#ByteList(int). I need to check if this is due to building on ARM64 or if it also reproduces on Intel.

@robertpanzer
Copy link
Member Author

Interestingly I don't seem to get this OOM on x86.
I'd like to stay conservative for now and stick with the older version.

I'll see over the weekend if I can somehow get hold of a heap dump and open a ticket once I have more information.

@abelsromero
Copy link
Member

I'd like to stay conservative for now and stick with the older version.

I think that's a good call.
If it helps, I run the build several times with 2 latests (v9.3.1.0 & v9.3.2.0) on Linux + Ryzen and it run fine and same time as this branch (3 min 1~3 sec). OOM could be an OS thing maybe?

@robertpanzer robertpanzer mentioned this pull request Jan 7, 2022
5 tasks
@robertpanzer
Copy link
Member Author

It looks like there is a problem with the MacOS specific implementation of fstat() which, for example, returns a file size of 976233465 instead of 111 bytes.
When reading such a file allocating the required memory fails of course. (It works a bit better when I run with -Xmx16000m lol)

I'll create a ticket for JRuby, but stick with the older version for now.

@robertpanzer
Copy link
Member Author

Created jruby/jruby#6988 to follow up on the memory issue.

@robertpanzer robertpanzer merged commit f54746e into asciidoctor:main Jan 8, 2022
@robertpanzer robertpanzer deleted the upgrade-asciidoctor-2.0.17 branch January 8, 2022 15:15
@robertpanzer
Copy link
Member Author

Updating jnr-posix to 3.1.15 seems to fix the OOM error.
I am still getting AccessDeniedExceptions.
It seems like JRuby support for M1 still has a few issues which seem to be fixed with 9.2.20.1.
So I assume that sticking with the older version is still the better option.

@robertpanzer
Copy link
Member Author

There are other issues with the permissions of files created by asciidoctorj-pdf.
These are also fixed by using jruby 9.3.2.0 (instead of jruby-complete) and jnr-posix 3.1.15 for the asciidoctorj-distribution tests.
So let's wait for that upgrade until there is a new version of JRuby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants