Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description of conversion process #1068

Closed
rockyallen opened this issue Dec 6, 2021 · 3 comments
Closed

Description of conversion process #1068

rockyallen opened this issue Dec 6, 2021 · 3 comments

Comments

@rockyallen
Copy link

On this page:
https://docs.asciidoctor.org/asciidoctorj/latest/extensions/conversion-process-overview/ (issue 2.5)
it says that
"Block macro, inline macro, and block processors are called during processing in the order that they appear in the document."
I don't think this is true. When I test it (v2.5.2) by doing prinltns, the sequence is: block macro and block processors interleaved in the order that they appear in the document, then inlines in the order they appear in the document.
I only tried a single file-I don't know if it is affected by includes.

The same page says "The different extension types are called in different steps of the conversion process in the order shown in the table. Within each type:"
I have no idea what this means. Type? Table?

@mojavelinux
Copy link
Member

then inlines in the order they appear in the document.

This is true for Asciidoctor as a whole and goes back to its inception. The inline elements are not processed until the convert phase, after all the blocks in the document have been parsed.

@robertpanzer
Copy link
Member

The same page says "The different extension types are called in different steps of the conversion process in the order shown in the table. Within each type:"
I have no idea what this means. Type? Table?

This probably got under the wheels when moving the original into the structure for the Antora site.
The original is still available in an older revision of the repo, for example here: https://github.com/asciidoctor/asciidoctorj/blob/86320bc1ab65cc0473cd8f4767ad36980331df3f/docs/integrator-guide.adoc#extend-asciidoctorj-write-your-own-extensions
I'll look at creating a PR to fix this.

@rockyallen
Copy link
Author

Thanks for the clarification.

robertpanzer added a commit to robertpanzer/asciidoctorj that referenced this issue Dec 7, 2021
robertpanzer added a commit that referenced this issue Jan 2, 2022
Fixes #1068. Clarify execution order of extensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants