Modernize cli #1067
Merged
Modernize cli #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
modernize-cli
branch
3 times, most recently
from
9e3f8ee
to
0aae689
Compare
abelsromero
commented
Nov 18, 2021
| + "' missing or cannot be read"); | ||
| }); | ||
|
|
||
| return inputFiles.stream() |
There was a problem hiding this comment.
I refactored this as-is, but the output is actually never used, maybe we should remove and just cal convert "for each" input?
There was a problem hiding this comment.
Yes, that would make sense. The method is also not part of any public API, so we can just remove the return value.
|
This looks good to me. |
Yes, thanks. I can find some time today. |
abelsromero
force-pushed
the
modernize-cli
branch
2 times, most recently
from
964d375
to
7e0d8de
Compare
* Removed unused imports * Applied Java8+ constructs * Formatting: unified code to use spaces * Remove AsciidoctorJ deprecated APIs when possible * Use AsciidoctorCliOptions.TIMINGS_OPTION_NAME constant in AsciidoctorInvoker
abelsromero
force-pushed
the
modernize-cli
branch
from
7e0d8de
to
6ae7609
Compare
|
Done 🥳 |
|
Awesome, thank you! 🙏🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a pull request and contributing to AsciidoctorJ!
Please take a bit of time giving some details about your pull request:
Kind of change
Description
What is the goal of this pull request?
How does it achieve that?
Are there any alternative ways to implement this?
Are there any implications of this pull request? Anything a user must know?
Test pass and I have not gone far in code changes just in case.
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #Issue
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc