Display upstream test in actions #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on my fork, this is how it looks https://github.com/abelsromero/asciidoctorj/actions/runs/1309264261
I must thank @spikymonkey for all his lessons on the topic 🥳 |
* Move scripts to folder to clean root path * Apply 'set -euo pipefail' to validate input & abort on error * 'test-asciidoctor-upstream.sh' refactor to reduce error prone practices
abelsromero
force-pushed
the
display-upstream-test-in-actions
branch
from
bbb2654
to
283b10f
Compare
|
Thanks! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a pull request and contributing to AsciidoctorJ!
Please take a bit of time giving some details about your pull request:
Kind of change
Description
What is the goal of this pull request?
Improve GH actions configuration to display Asciidoctor upstream test.
How does it achieve that?
Extracts previous step of
buildjob into its own job.The new job will run when linux, mac & windows build succeed.
Are there any alternative ways to implement this?
We could maintin it as it is, the problem is that to check if upstream is running, we need to go into a specific build job..several clicks...and find the step in the UI. This is not convenient and it's easy to miss if test upstream step is not running.
Are there any implications of this pull request? Anything a user must know?
Also relocates & refactors
test-asciidoctor-upstream.shto clean root path, and apply some bash patterns to avoid typical pitfalls.Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #Issue
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc