Skip to content

use a custom css with disableLayout option of revealjs #381

Closed
@g4gilson

Description

@g4gilson

Hi, I'm trying to set the disableLayout option to true but the option seems to be not supported or don't work with the syntax:

:revealjs_disableLayout: true

in .adoc files.
I wonder how can I use this option with asciidoctor-reveal.js or have a similar behaviour with another trick and why this option seems to be deliberated avoid

Activity

g4gilson

g4gilson commented on Oct 1, 2020

@g4gilson
Author

Was working with a custom reveal js on my computer. Issue still open

ggrossetie

ggrossetie commented on Nov 28, 2020

@ggrossetie
Member

This option is currently not supported by the converter.
If you want to contribute this feature, you will need to add it in templates/document.html.slim.

You can take inspiration from revealjs_help:

help: #{to_boolean(attr 'revealjs_help', true)},

For reference, here's the reveal.js default configuration: https://github.com/hakimel/reveal.js/blob/94d98ff7d89e35c7d5b289ba387cdb0d42b30793/js/reveal.js#L115-L117

And here's what you would need to add in the document.html.slim file:

  disableLayout: #{to_boolean(attr 'revealjs_disablelayout', false)}, 
added this to the 4.1.0 milestone on Dec 4, 2020
ggrossetie

ggrossetie commented on Dec 4, 2020

@ggrossetie
Member

@g4gilson I plan to include this enhancement/fix as part of the next release. Do you want to contribute it or should I go forward and take care of it?

g4gilson

g4gilson commented on Dec 7, 2020

@g4gilson
Author

If that don't bother you, you can take care of it. I had some difficulties to make the building environment and your previous answer is what I was thinking to add it 👍 . Thank you for your answer :)

ggrossetie

ggrossetie commented on Dec 7, 2020

@ggrossetie
Member

No worries, I will take care of it.
Thanks for reporting this issue 👍

added a commit that references this issue on Dec 7, 2020

resolves asciidoctor#381 allow to configure disableLayout

e88d4c3
added a commit that references this issue on Dec 7, 2020

resolves asciidoctor#381 allow to configure disableLayout

4e052e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      Participants

      @ggrossetie@g4gilson

      Issue actions

        use a custom css with disableLayout option of revealjs · Issue #381 · asciidoctor/asciidoctor-reveal.js