Closed
Description
Hello,
I'm trying to build 1.6.0 for F35 and seeing the following error:
Run options: exclude {:network=>true}
..................................................................................F....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Failures:
1) Asciidoctor::PDF::Converter - Dest should keep anchor with text if text is advanced to next page
Failure/Error: (expect names).to have_key 'anchor'
expected `{"__anchor-top"=>#<PDF::Reader::Reference:0x000055f7c5ef55e8 @id=8, @gen=0>}.has_key?("anchor")` to be truthy, got false
# ./spec/dest_spec.rb:51:in `block (2 levels) in <top (required)>'
Finished in 1 minute 31.55 seconds (files took 0.58091 seconds to load)
983 examples, 1 failure
Failed examples:
rspec ./spec/dest_spec.rb:41 # Asciidoctor::PDF::Converter - Dest should keep anchor with text if text is advanced to next page
Any ideas as to the cause appreciated.
Metadata
Metadata
Assignees
Type
Projects
Relationships
Development
No branches or pull requests
Activity
mojavelinux commentedon Sep 2, 2021
I'm pretty sure this is due to a breaking change that Prawn made in a recent release. I have applied at least one patch for this test case already, but perhaps there is another case I'm not considering.
Please share the version of Ruby and the version of Prawn that Asciidoctor PDF is using when running this test.
snecklifter commentedon Sep 3, 2021
@mojavelinux thanks:
Ruby: 3.0.2
Prawn: 2.4.0
mojavelinux commentedon Sep 3, 2021
Aha. Now I see. The patch I made came after the 1.6.0 release. So the combination of Asciidoctor PDF 1.6.0 with Prawn 2.4.0 does not pass the test suite. But if you apply this patch to Asciidoctor PDF, the test will pass: 77e4671
What I need to do is release 1.6.1. I'll plan to do that sometime in the next few days.
mojavelinux commentedon Sep 3, 2021
That test is important too, because it's validating that non-visible metadata is preserved during rendering. That's what the Prawn release broke.
snecklifter commentedon Sep 3, 2021
@mojavelinux thanks, have tested and when that patch is applied I get:
snecklifter commentedon Sep 3, 2021
Am just missing arranger.rb so will wait for 1.6.1 I think.
add missing CHANGELOG entry for #1963 [skip ci]