Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of monospaced table cells #1601

Closed
sdavids opened this issue Apr 15, 2024 · 3 comments
Closed

Handling of monospaced table cells #1601

sdavids opened this issue Apr 15, 2024 · 3 comments
Labels

Comments

@sdavids
Copy link

sdavids commented Apr 15, 2024

Observed vs. expected behavior

The baseline is incorrect and the color does not adjust to the OS' dark mode.

JCEF Browser

light

dark

baseline

Reference

AsciiDoc - Format Content by Cell

Steps to reproduce

[%header,cols=",^m,<m,>m"]
|===

|A | B | C | D

|1
|2
|3
|4

|===

Environment

Plugin Version: 0.41.13

IntelliJ IDEA 2024.1 (Community Edition)
Build #IC-241.14494.240, built on March 28, 2024
Runtime version: 17.0.10+8-b1207.12 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 12.7.4
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 8
Metal Rendering is ON
Registry:
ide.experimental.ui=true
Non-Bundled Plugins:
org.asciidoctor.intellij.asciidoc (0.41.13)
Kotlin: 241.14494.240-IJ

@sdavids sdavids added the bug label Apr 15, 2024
@sdavids sdavids changed the title Handling of table cell styles Handling of monospaced table cell styles Apr 15, 2024
@sdavids sdavids changed the title Handling of monospaced table cell styles Handling of monospaced table cells Apr 15, 2024
@ahus1
Copy link
Contributor

ahus1 commented May 26, 2024

@sdavids - thank you for raising this issue. The dark mode you see is part of the AsciiDoc plugin, and I'll take care of it in this issue.

The vertical alignment issue you reported here is part of the CSS stylesheet maintained by the Asciidoctor project. Please report the issue against that project: https://github.com/asciidoctor/asciidoctor

@ahus1
Copy link
Contributor

ahus1 commented May 26, 2024

Thank you for sharing the reproducer. The next version of the plugin will render this better.

The following example:

test is `a` test

[%header,cols=",^m,<m,>m"]
|===

|A | B | C | D

|1
|2
|3
|4

|===

Before:

image

After:

image

I'll update this issue once a preview version is available.

@ahus1
Copy link
Contributor

ahus1 commented May 30, 2024

The changes are available as part of version 0.41.15 of the plugin which is currently available as a pre-release.

The pre-release of the plugin is available from GitHub releases and the IntelliJ AsciiDoc EAP repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants