-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move kindlegen out of optional deps #270
Comments
Aaaargh, we can't because it is conditional =/ I'm not sure how to fix this then. |
I'd go ahead and make it a regular dependency.
|
If 3.0.3 is added to gemspec, it can't be installed on Windows (#213). If 3.0.5 is added to gemspec, we lose Ruby 2.3 support (tdtds/kindlegen@8c3b29c). And kindlegen maintainer already rejected lowering required Ruby version to 2.3. |
Okay, I think I figured out how to handle this: #272. |
The range is the correct thing to do. It allows the kindlegen gem to be installed first (or via Bundler), and installing this gem won't try to upgrade it. You might not want to make the top of the range so specific. I think |
kindlegen doesn't follow semantic versioning (they raised Ruby version from 2.3 to 2.4 in kindlegen-3.0.4), so I'd prefer to play safe here. |
This will be undone, see #288. |
Users suffer (#268):
@mojavelinux Do you have arguments against this?
The text was updated successfully, but these errors were encountered: