Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kindlegen out of optional deps #270

Closed
slonopotamus opened this issue Jan 26, 2020 · 7 comments
Closed

Move kindlegen out of optional deps #270

slonopotamus opened this issue Jan 26, 2020 · 7 comments

Comments

@slonopotamus
Copy link
Contributor

Users suffer (#268):

$ gem install asciidoctor-epub3 --pre
$ asciidoctor -b epub3 -r asciidoctor-epub3 -a ebook-format=kf8 book.adoc
cannot load such file -- kindlegen
  Use --trace for backtrace

@mojavelinux Do you have arguments against this?

@slonopotamus
Copy link
Contributor Author

Aaaargh, we can't because it is conditional =/ I'm not sure how to fix this then.

@mojavelinux
Copy link
Member

mojavelinux commented Jan 26, 2020 via email

@slonopotamus
Copy link
Contributor Author

slonopotamus commented Jan 27, 2020

If 3.0.3 is added to gemspec, it can't be installed on Windows (#213). If 3.0.5 is added to gemspec, we lose Ruby 2.3 support (tdtds/kindlegen@8c3b29c). And kindlegen maintainer already rejected lowering required Ruby version to 2.3.

slonopotamus added a commit to slonopotamus/asciidoctor-epub3 that referenced this issue Jan 27, 2020
@slonopotamus
Copy link
Contributor Author

Okay, I think I figured out how to handle this: #272.

@mojavelinux
Copy link
Member

The range is the correct thing to do. It allows the kindlegen gem to be installed first (or via Bundler), and installing this gem won't try to upgrade it.

You might not want to make the top of the range so specific. I think < 3.1.0 would be sufficient.

@slonopotamus
Copy link
Contributor Author

kindlegen doesn't follow semantic versioning (they raised Ruby version from 2.3 to 2.4 in kindlegen-3.0.4), so I'd prefer to play safe here.

slonopotamus added a commit to slonopotamus/asciidoctor-epub3 that referenced this issue Jan 27, 2020
@slonopotamus
Copy link
Contributor Author

This will be undone, see #288.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants