You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm following up with the discussion here ColinEberhardt/assemblyscript-regex#35 where I was a bit surprised to realized that the toThrow assertion doesn't check the error message (only that something is actually thrown).
Looking at the code my understanding is that the message sent to toThrow is used only when the assertion fails.
Would that make sense to change the API and have the thrown message be checked?
(maybe with an "include" at first since RegExp are not natively implemented in AS?)
Happy to work on a PR if that makes sense.
Thanks!
The text was updated successfully, but these errors were encountered:
Hi!
Thanks for this great project!
I'm following up with the discussion here ColinEberhardt/assemblyscript-regex#35 where I was a bit surprised to realized that the
toThrow
assertion doesn't check the error message (only that something is actually thrown).Looking at the code my understanding is that the
message
sent totoThrow
is used only when the assertion fails.Would that make sense to change the API and have the thrown message be checked?
(maybe with an "include" at first since RegExp are not natively implemented in AS?)
Happy to work on a PR if that makes sense.
Thanks!
The text was updated successfully, but these errors were encountered: