Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display objects from component dependency differently #22

Open
tir38 opened this issue Jan 2, 2020 · 3 comments
Open

Display objects from component dependency differently #22

tir38 opened this issue Jan 2, 2020 · 3 comments
Labels
enhancement New feature or request module:processor Label to mark all discussions about scabbard's annotation processor needs investigation Needs investigation to determine course of action

Comments

@tir38
Copy link

tir38 commented Jan 2, 2020

Part of our overall object graph looks like this:

io orionlabs android feature media di MediaComponent

Some of these objects in the graph are coming from a component dependency:

@Component(
        modules = {
                MediaModule.class
        },
        dependencies = {
                SomeOtherComponent.class
        }
)
public interface MediaComponent {...}

You can probably infer which ones are coming from SomeOtherComponent based on package name. It would be nice if these were either color coded differently than those supplied by MediaModule, or maybe even put them in another box inside "object graph".

@arunkumar9t2 arunkumar9t2 added module:processor Label to mark all discussions about scabbard's annotation processor enhancement New feature or request labels Jan 3, 2020
@arunkumar9t2
Copy link
Owner

Agreed, although package name might not be a universal solution for all projects. I'll check if there is something in the Dagger SPI to differentiate dependencies.

@tir38
Copy link
Author

tir38 commented Jan 6, 2020

I just meant in my case the package name would show you what I'm talking about. I don't think relying on package name to infer component is the right programmatic solution. =)

@arunkumar9t2 arunkumar9t2 added the needs investigation Needs investigation to determine course of action label Jan 7, 2020
@arunkumar9t2 arunkumar9t2 added this to To do in Scabbard Development via automation Apr 24, 2021
arunkumar9t2 added a commit that referenced this issue Jul 20, 2022
arunkumar9t2 added a commit that referenced this issue Jul 21, 2022
* Add component with dependencies sample.

Related #22

* Add binding from dependant component as entry point
@arunkumar9t2
Copy link
Owner

This was blocked by google/dagger#3483. Now that is implemented in Dagger, I will try to display component dependencies differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module:processor Label to mark all discussions about scabbard's annotation processor needs investigation Needs investigation to determine course of action
Projects
Development

No branches or pull requests

2 participants