Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

[Dev] Deployment doesn't work because of our custom RN source code changes #971

Open
orta opened this issue Jan 29, 2018 · 2 comments
Open

Comments

@orta
Copy link
Contributor

orta commented Jan 29, 2018

handled in our package.json:

    "postinstall":
      "sed -i '' 's/#import <RCTAnimation\\/RCTValueAnimatedNode.h>/#import \"RCTValueAnimatedNode.h\"/' ./node_modules/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h && ./scripts/post_installs.sh || true",

causes on pod repo push

/var/folders/xh/sh5y6m0d0t75_qzr362llyvw0000gn/T/CocoaPods-Lint-20180129-43934-j1hist-Emission/Pods/React/Libraries/NativeAnimation/RCTNativeAnimatedModule.m -o /Users/orta/Library/Developer/Xcode/DerivedData/App-ftbkkrgoykfxgjdhnatblwkpawcn/Build/Intermediates.noindex/Pods.build/Release-iphonesimulator/React.build/Objects-normal/i386/RCTNativeAnimatedModule.o
In file included from /var/folders/xh/sh5y6m0d0t75_qzr362llyvw0000gn/T/CocoaPods-Lint-20180129-43934-j1hist-Emission/Pods/React/Libraries/NativeAnimation/RCTNativeAnimatedModule.m:11:
/var/folders/xh/sh5y6m0d0t75_qzr362llyvw0000gn/T/CocoaPods-Lint-20180129-43934-j1hist-Emission/Pods/React/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h:12:9: fatal error: 'RCTAnimation/RCTValueAnimatedNode.h' file not found
#import <RCTAnimation/RCTValueAnimatedNode.h>
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

currently "fixing" by editing my cocoapods to not validate new pods

@orta
Copy link
Contributor Author

orta commented Jan 29, 2018

@mennenia
Copy link
Contributor

We came across this today (new error):

Validating spec
 -> Emission (1.5.0)
    - WARN  | [iOS] attributes: Unrecognized `native_version` key.
    - ERROR | [iOS] unknown: Encountered an unknown error (Unable to find a specification for `yoga (= 0.54.4.React)` depended upon by `Emission`) during validation.

[!] The `Emission.podspec` specification does not validate.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants