Skip to content

Feature/v1.6.x support case sensitive headers #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jmclean-cnexus
Copy link

Allows for case sensitive headers, so long as config has below:
caseSensitive: true

If the above is not configured, default will be set to false, and prior functionality will persist

@jmclean-cnexus
Copy link
Author

@hassy - please let me know your thoughts on this PR

@hassy
Copy link
Member

hassy commented May 15, 2020

Thanks for the PR @jmclean-cnexus. I agree on the need to provide a way to maintain the casing of headers for servers that don't respect the HTTP spec. The complication we have to deal with is the move from Request.js to Got.js (#802). While Request respects the casing, Got.js seems to always lowercase request headers without a way to turn that off. Since the next major release of Artillery will use Got.js we'd need to find a way to make that work.

@jmclean-cnexus
Copy link
Author

@hassy agreed! For version 1.6.x, can we merge this. I would be happy to help out w/ the future release if needed. 1.6.x, I would imagine, would not incorporate Got.js.

@jmclean-cnexus
Copy link
Author

@hassy just following up on this. I can do a workaround for my local use case by just overwriting the source file w/ the one in this pull request...but i know other people were asking for this capability. BTW...any reason for doing Got.js v axios? just curious...i know there are 10000 ways to skin a cat, but curious what your motive is.

@dandenton
Copy link

dandenton commented May 26, 2020

FYI this would help with #828 (just to link the two)

@jmclean-cnexus
Copy link
Author

@hassy I know you're a busy guy, but any/all comments are appreciated.

@hassy hassy merged commit 8e204ec into artilleryio:v1.6.x Jun 11, 2020
@hassy
Copy link
Member

hassy commented Jun 11, 2020

Merged, thanks for the PR @jmclean-cnexus!

@jmclean-cnexus jmclean-cnexus deleted the feature/v1.6.x-support-case-sensitive-headers branch June 11, 2020 12:41
@hassy
Copy link
Member

hassy commented Jun 30, 2020

and published in 1.6.1 now! thanks again @jmclean-cnexus!

@BhavnaSoni1991
Copy link

@hassy , @bernardobridge Can anyone please comment if the fix for this issue is rolled back in latest releases as I am facing this issue in my test where the header name is getting changed to lower case and the tests are failing because of that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants