Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify type_hints.py with the typing_inspect package #290

Open
JacobHayes opened this issue Nov 28, 2022 · 0 comments
Open

Simplify type_hints.py with the typing_inspect package #290

JacobHayes opened this issue Nov 28, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@JacobHayes
Copy link
Member

JacobHayes commented Nov 28, 2022

The src/arti/internal/type_hints.py module has a number of helpers to handle python version compatibility and other runtime checking things. The typing_inspect package would likely simplify a good bit of that code, reducing the effort to add support for newer python versions and typing features.

Alternatively, pydantic 2's strict mode may remove the need for a lot of that code anyway. We should likely wait for that to see what is still needed.

@JacobHayes JacobHayes added the enhancement New feature or request label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant