Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support optional deps or separate arti-* packages for connectors #112

Open
JacobHayes opened this issue Nov 3, 2021 · 0 comments
Open

Comments

@JacobHayes
Copy link
Member

Eg: we'll be adding a gcsfs dep soon for a GCSFile(Storage). This shouldn't be required for all users.

We do some dynamic submodule imports in a few spots in the code base that might cause some trouble with optional deps. If we do keep these contrib connectors in-tree (as opposed to moving to arti-* packages that extend the namespace), we'll need to make sure those skip gracefully. Perhaps we add a custom import error class that we can raise in our "optional" modules (and then catch that in import_submodules).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant