Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Float seconds argument to Time::at #2090

Open
lopopolo opened this issue Aug 21, 2022 · 0 comments
Open

Handle Float seconds argument to Time::at #2090

lopopolo opened this issue Aug 21, 2022 · 0 comments
Labels
A-ruby-core Area: Ruby Core types. B-mruby Backend: Implementation of artichoke-core using mruby.

Comments

@lopopolo
Copy link
Member

This PR is already getting a bit large, but I know that this line isn't 100% correct either - and that we need to do the ol float/to_i dance.

[3.1.2]> Time.at(1.5, 1500000, :usec).to_f
=> 3.0

☝️ Yep, 1.5seconds + 1.5seconds = 3 seconds!

Better to do in this PR or in the next?

Originally posted by @b-n in #1956 (comment)
@lopopolo lopopolo added A-ruby-core Area: Ruby Core types. B-mruby Backend: Implementation of artichoke-core using mruby. labels Aug 21, 2022
@lopopolo lopopolo mentioned this issue Aug 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ruby-core Area: Ruby Core types. B-mruby Backend: Implementation of artichoke-core using mruby.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lopopolo