New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement mrb_raise with panic #35

Open

lopopolo opened this issue Jul 8, 2019 · 6 comments · May be fixed by #1904

Labels

A-C-API A-vm B-mruby CAPI-mruby S-blocked

Member

lopopolo commented Jul 8, 2019

The gymnastics and sad times in artichoke/ferrocarril#168 become unnecessary if we have a memory safe unwind. panic is exactly that.

Implement mrb_raise, mrb_raisef and mrb_protect in Rust in mrb-sys exported to C so libmruby can use them.

The text was updated successfully, but these errors were encountered:

Member Author

lopopolo commented Jul 8, 2019

This will allow removing the dependency on mruby-error mrbgem.

Eval and Funcall would implement "catch" with panic::catch_unwind.

Member Author

lopopolo commented Jul 8, 2019 •

edited

Add the test for the TODO in artichoke/ferrocarril#168.

Psuedo code, called in a loop 100 times. This is expected to leak 100MB.

unsafe extern "C" throws(mrb, slf) {
    let interp = unwrap_interpreter(mrb);
    let s = Box::new(std::iter::repeat("a").take(1024 * 1024).collect::<String>());
    RuntimeError::raise(interp, "oh no")
}

lopopolo transferred this issue from artichoke/ferrocarril

lopopolo added this to the VM milestone

lopopolo added Backend: mruby CAPI-mruby labels

Member Author

lopopolo commented Aug 5, 2019

This is currently blocked on rust-lang/rfcs#2699.

lopopolo added S-blocked A-vm A-C-API labels

lopopolo removed this from the VM milestone

lopopolo mentioned this issue

Fix premature test abort in Windows #386

Closed

github-actions bot removed the B-mruby label

lopopolo added the B-mruby label

Member Author

lopopolo commented Aug 25, 2020

The linked RFC resulted in unwind ABIs: https://rust-lang.github.io/rfcs/2945-c-unwind-abi.html

Upstream tracking issue: rust-lang/rust#74990

lopopolo mentioned this issue

Implement mrb_protect and exception raising with panic! and catch_unwind #1029

Closed

Member Author

lopopolo commented Mar 25, 2021

The C-unwind ABI has been implemented and is currently on nightly: rust-lang/rust#76570.

Member Author

lopopolo commented Jun 10, 2022

this is happening! rust-lang/rfcs#2945 (comment)

lopopolo added a commit that referenced this issue


          Enable c_unwind feature

3b8569d

The Rust team has put out a call for testing on the `c_unwind` feature
and associated `C-unwind` ABI:

- rust-lang/rfcs#2945 (comment)

I intend to implement mruby's exception unwinding using Rust's panic
infrastructure:

- #35

This commit changes the Rust toolchain to nightly for this test. Merging
this experiment will be blocked on the `C-unwind` ABI making it to
stable.

lopopolo added a commit that referenced this issue


          Remove mruby-error mrbgem from artichoke-backend

2be43f7

`mruby-error` implements `mrb_protect` and `mrb_ensure`. These two
functions are used to stop the propagation of exception unwinding in
mruby, which natively uses either `setjmp`/`longjmp` or C++'s `catch`
and `throw`.

I intend to reimplement these functions in Rust using Rust panics:
`std::panic::catch_unwind` and `std::panic::panic_any`.

See:

- #35

lopopolo linked a pull request

that will close this issue

Implement mrb_raise with Rust panic! #1904

Open

lopopolo mentioned this issue

Cherry-pick C++ with C ABI fixes artichoke/mruby#11

Closed

lopopolo added a commit that referenced this issue


          Enable c_unwind feature

806da7c

The Rust team has put out a call for testing on the `c_unwind` feature
and associated `C-unwind` ABI:

- rust-lang/rfcs#2945 (comment)

I intend to implement mruby's exception unwinding using Rust's panic
infrastructure:

- #35

This commit changes the Rust toolchain to nightly for this test. Merging
this experiment will be blocked on the `C-unwind` ABI making it to
stable.

lopopolo added a commit that referenced this issue


          Remove mruby-error mrbgem from artichoke-backend

9c5ab3f

`mruby-error` implements `mrb_protect` and `mrb_ensure`. These two
functions are used to stop the propagation of exception unwinding in
mruby, which natively uses either `setjmp`/`longjmp` or C++'s `catch`
and `throw`.

I intend to reimplement these functions in Rust using Rust panics:
`std::panic::catch_unwind` and `std::panic::panic_any`.

See:

- #35

lopopolo added a commit that referenced this issue


          Enable c_unwind feature

ca4edec

The Rust team has put out a call for testing on the `c_unwind` feature
and associated `C-unwind` ABI:

- rust-lang/rfcs#2945 (comment)

I intend to implement mruby's exception unwinding using Rust's panic
infrastructure:

- #35

This commit changes the Rust toolchain to nightly for this test. Merging
this experiment will be blocked on the `C-unwind` ABI making it to
stable.

lopopolo added a commit that referenced this issue


          Remove mruby-error mrbgem from artichoke-backend

bea6735

`mruby-error` implements `mrb_protect` and `mrb_ensure`. These two
functions are used to stop the propagation of exception unwinding in
mruby, which natively uses either `setjmp`/`longjmp` or C++'s `catch`
and `throw`.

I intend to reimplement these functions in Rust using Rust panics:
`std::panic::catch_unwind` and `std::panic::panic_any`.

See:

- #35

lopopolo added a commit that referenced this issue


          Enable c_unwind feature

The Rust team has put out a call for testing on the `c_unwind` feature
and associated `C-unwind` ABI:

- rust-lang/rfcs#2945 (comment)

I intend to implement mruby's exception unwinding using Rust's panic
infrastructure:

- #35

This commit changes the Rust toolchain to nightly for this test. Merging
this experiment will be blocked on the `C-unwind` ABI making it to
stable.

lopopolo added a commit that referenced this issue


          Remove mruby-error mrbgem from artichoke-backend

ad1cb4f

`mruby-error` implements `mrb_protect` and `mrb_ensure`. These two
functions are used to stop the propagation of exception unwinding in
mruby, which natively uses either `setjmp`/`longjmp` or C++'s `catch`
and `throw`.

I intend to reimplement these functions in Rust using Rust panics:
`std::panic::catch_unwind` and `std::panic::panic_any`.

See:

- #35

lopopolo added a commit that referenced this issue


          Enable c_unwind feature

6019f9f

The Rust team has put out a call for testing on the `c_unwind` feature
and associated `C-unwind` ABI:

- rust-lang/rfcs#2945 (comment)

I intend to implement mruby's exception unwinding using Rust's panic
infrastructure:

- #35

This commit changes the Rust toolchain to nightly for this test. Merging
this experiment will be blocked on the `C-unwind` ABI making it to
stable.

lopopolo added a commit that referenced this issue


          Remove mruby-error mrbgem from artichoke-backend

e1dde7d

`mruby-error` implements `mrb_protect` and `mrb_ensure`. These two
functions are used to stop the propagation of exception unwinding in
mruby, which natively uses either `setjmp`/`longjmp` or C++'s `catch`
and `throw`.

I intend to reimplement these functions in Rust using Rust panics:
`std::panic::catch_unwind` and `std::panic::panic_any`.

See:

- #35

lopopolo added a commit that referenced this issue


          Enable c_unwind feature

6c78ab6

The Rust team has put out a call for testing on the `c_unwind` feature
and associated `C-unwind` ABI:

- rust-lang/rfcs#2945 (comment)

I intend to implement mruby's exception unwinding using Rust's panic
infrastructure:

- #35

This commit changes the Rust toolchain to nightly for this test. Merging
this experiment will be blocked on the `C-unwind` ABI making it to
stable.

lopopolo added a commit that referenced this issue


          Remove mruby-error mrbgem from artichoke-backend

fded88b

`mruby-error` implements `mrb_protect` and `mrb_ensure`. These two
functions are used to stop the propagation of exception unwinding in
mruby, which natively uses either `setjmp`/`longjmp` or C++'s `catch`
and `throw`.

I intend to reimplement these functions in Rust using Rust panics:
`std::panic::catch_unwind` and `std::panic::panic_any`.

See:

- #35

lopopolo added a commit that referenced this issue


          Enable c_unwind feature

0dffa06

The Rust team has put out a call for testing on the `c_unwind` feature
and associated `C-unwind` ABI:

- rust-lang/rfcs#2945 (comment)

I intend to implement mruby's exception unwinding using Rust's panic
infrastructure:

- #35

This commit changes the Rust toolchain to nightly for this test. Merging
this experiment will be blocked on the `C-unwind` ABI making it to
stable.

lopopolo added a commit that referenced this issue


          Remove mruby-error mrbgem from artichoke-backend

f006cf1

`mruby-error` implements `mrb_protect` and `mrb_ensure`. These two
functions are used to stop the propagation of exception unwinding in
mruby, which natively uses either `setjmp`/`longjmp` or C++'s `catch`
and `throw`.

I intend to reimplement these functions in Rust using Rust panics:
`std::panic::catch_unwind` and `std::panic::panic_any`.

See:

- #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment