Bump version to 1.1.0 and update CHANGELOG #963
Conversation
Codecov Report
@@ Coverage Diff @@
## master #963 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 10 10
Lines 2014 2014
Branches 323 323
=======================================
Hits 2009 2009
Misses 4 4
Partials 1 1
Continue to review full report at Codecov.
|
CHANGELOG.rst
Outdated
|
|
||
| - [NEW] Added Croatian, Latin, Latvian, Lithuanian and Malay locales. | ||
| - [FIX] Internally standardize locales and improve locale validation. | ||
| - [FIX] Correct type checking for ``arrow.get(2021, 3, 9)`` construction and internal locale mapping. |
There was a problem hiding this comment.
Do we want to include an example of subclassing a custom locale like Isac mentioned in his PR: #920.
There was a problem hiding this comment.
Was that available before his PR?
There was a problem hiding this comment.
According to Isac it was not, but we can verify on the current stable.
CHANGELOG.rst
Outdated
| (<Arrow [2021-04-22T00:00:00+00:00]>, <Arrow [2021-04-28T23:59:59.999999+00:00]>) | ||
|
|
||
| - [NEW] Added Croatian, Latin, Latvian, Lithuanian and Malay locales. | ||
| - [FIX] Internally standardize locales and improve locale validation. |
There was a problem hiding this comment.
Should we put a note that locales should use official ISO notation of the dash rather than underscore, but the change is backward compatible? Or do you think it will just catch on over time with the updated docs?
There was a problem hiding this comment.
I think that's a good idea to give people a headsup.
|
@jadchaar all good to go here? |
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
toxormake testto find out!).tox -e lintormake lintto find out!).masterbranch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
Bump minor number due to non breaking feature additions.