Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with tzinfo.zone check in factory.get #664

Merged
merged 2 commits into from Sep 10, 2019
Merged

Fix bug with tzinfo.zone check in factory.get #664

merged 2 commits into from Sep 10, 2019

Conversation

jadchaar
Copy link
Member

Closes: #658

@codecov-io
Copy link

Codecov Report

Merging #664 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #664   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines        1536   1536           
  Branches      244    244           
=====================================
  Hits         1536   1536
Impacted Files Coverage Δ
arrow/arrow.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 256e53f...f49cd84. Read the comment docs.

Copy link
Collaborator

@systemcatch systemcatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jadchaar jadchaar merged commit 5b0d2a7 into arrow-py:master Sep 10, 2019
@jadchaar jadchaar deleted the tzinfo-zone branch September 10, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contructor issue with non-None timezone
3 participants