Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.15.0 regression - Support negative numbers in the timestamp regular expression #663

Merged
merged 3 commits into from Sep 10, 2019

Conversation

JBKahn
Copy link
Contributor

@JBKahn JBKahn commented Sep 10, 2019

This solves #662

Currently arrow does not allow you to pass in negative numbers for seconds relative to epoch when using strings. This patch is an attempt to fix this.

@JBKahn JBKahn changed the title Support negative numbers in the timestamp regular expression 0.15 regression - Support negative numbers in the timestamp regular expression Sep 10, 2019
@JBKahn
Copy link
Contributor Author

JBKahn commented Sep 10, 2019

If this is a-ok could you cut a release for this?

@codecov-io
Copy link

codecov-io commented Sep 10, 2019

Codecov Report

Merging #663 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #663   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines        1536   1536           
  Branches      244    244           
=====================================
  Hits         1536   1536
Impacted Files Coverage Δ
arrow/parser.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b05216...1974316. Read the comment docs.

@systemcatch
Copy link
Collaborator

Thanks @JBKahn, we'll look this over then merge if it's all good. We're probably going to wait a little before releasing 0.15.1 in case any more obvious bugs arise. Is this one really messing you guys up?

@JBKahn
Copy link
Contributor Author

JBKahn commented Sep 10, 2019

Yeah, especially since a lot of apps don't lock down the version and we have lots of historical dates being passed into arrow.

@systemcatch systemcatch changed the title 0.15 regression - Support negative numbers in the timestamp regular expression 0.15.0 regression - Support negative numbers in the timestamp regular expression Sep 10, 2019
@systemcatch
Copy link
Collaborator

Alright we'll speed things along then.

Copy link
Member

@jadchaar jadchaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jadchaar jadchaar merged commit 256e53f into arrow-py:master Sep 10, 2019
@JBKahn JBKahn deleted the patch-1 branch September 10, 2019 17:23
@JBKahn
Copy link
Contributor Author

JBKahn commented Sep 10, 2019

Thanks, already had some issues with some places automatically picking up 0.15.0 if they din't lock the version and it was a sub-dependancy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants