Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.humanize() should have a numeric option for 1 instead of a/an #1158

Open
julianLapenna12 opened this issue Jul 14, 2023 · 3 comments
Open

Comments

@julianLapenna12
Copy link

Feature Request

Option to change "a/an" to 1:

  • "2 hours and a minute" --> "2 hours and 1 minute"
  • "an hour and 12 minutes" --> "1 hour and 12 minutes"
  • etc.

example Arrow.humanize(..., numeric=True)

@yiransii
Copy link
Contributor

yiransii commented Aug 4, 2023

I can take on this if someone can verify what's the intended behavior here. From your example, it's hard to tell how is 1 hour much better than an hour

@julianLapenna12
Copy link
Author

The only difference is readability. I have an app that displays times which areow is great for, but when I have multiple listed, people have misinterpreted no number as 0 hours. For example:

Team Time
Blue 2 hours and 3 minutes
Red 3 hours and 47 minutes
Yellow an hour and 58 minutes
Green 2 hours and 39 minutes
Purple 4 hours and 2 minutes

In something similar to this (but larger), I guess when someone skims they don't see a digit and assume 0?

Does that give better context? Let me know if there are other questions.

@ganesh-palanikumar
Copy link

@julianLapenna12 If this is still required (and @yiransii is not actively working on this), I can take this up. Have worked with arrow and would love to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants