Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release plan #4

Closed
8 tasks done
arokettu opened this issue Sep 15, 2022 · 5 comments
Closed
8 tasks done

Release plan #4

arokettu opened this issue Sep 15, 2022 · 5 comments

Comments

@arokettu
Copy link
Owner

arokettu commented Sep 15, 2022

Postpone final release until PHP 8.2 final release

  • RC 1 compatibility (done in beta 1)
  • RC 2 compatibility (done in rc 1)
  • RC 3 compatibility
  • RC 4 compatibility
  • RC 5 compatibility
  • RC 6 compatibility (done by Fixes php-src#9839 compatibility #5 in 1.0.1)
  • RC 7 compatibility
  • Release compatibility
@TimWolla
Copy link

FYI: php/php-src#9839. Not yet merged due to one pending review, but this will become part of RC 6.

@arokettu
Copy link
Owner Author

@TimWolla Thanks. It seems it doesn't affect the object behavior and my tests still pass

@TimWolla
Copy link

TimWolla commented Oct 27, 2022

The output for the following will change to match PHP 7.3 to 8.1:

<?php

mt_srand(1, MT_RAND_PHP);

var_dump(str_shuffle('0123456789'));

if (class_exists(Random\Randomizer::class)) {
    $r = new Random\Randomizer(new Random\Engine\Mt19937(1, MT_RAND_PHP));
    var_dump($r->shuffleBytes('0123456789'));
}

https://3v4l.org/v8jFO

see:

$ g rev-parse HEAD
b9bee155a9c68a3c4ba70b9255a3aea5ee2570bc
$ make -j4 >/dev/null 2>&1
$ sapi/cli/php test.php
string(10) "8926013475"
string(10) "8926013475"
$ g co HEAD^
HEAD is now at 1ba80ff95c Merge branch 'PHP-8.1' into PHP-8.2
$ g rev-parse HEAD
1ba80ff95c926389be836c4cb82982fb2b578b13
$ make -j4 >/dev/null 2>&1
$ sapi/cli/php test.php
string(10) "8132476905"
string(10) "8132476905"

@TimWolla
Copy link

@arokettu I've just merged the previously linked PR.

@arokettu
Copy link
Owner Author

Ok, I see. I fixed it in #5, I will merge it once RC6 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants