inmem: allow streaming of metrics as intervals complete #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
force-pushed
the
dnephin/stream-metrics
branch
from
3d15a58
to
7713fa0
Compare
dnephin
commented
Jun 10, 2021
These functions were only called in a single place, and repeated some of the same logic. This change is made in preparation for streaming metrics.
dnephin
force-pushed
the
dnephin/stream-metrics
branch
from
7713fa0
to
b1da2f8
Compare
dnephin
commented
Jun 10, 2021
dnephin
force-pushed
the
dnephin/stream-metrics
branch
from
b1da2f8
to
980bc52
Compare
banks
reviewed
Jun 11, 2021
dnephin
commented
Jun 11, 2021
This will allow `consul debug` to include all the metrics, instead of missing many metrics.
dnephin
force-pushed
the
dnephin/stream-metrics
branch
from
980bc52
to
056fff3
Compare
|
I pushed another commit which reduces the interface that I think this is ready for merge now. |
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to one of the items in hashicorp/consul#10320
We use the
InMemSinkto capture metrics for the debug archive, but the previous implementation resulted in us missing a lot of metrics because only 1/3 of the intervals were captured. Attempting to request the metrics at each interval is a challenge (maybe impossible), so instead this PR adds for an HTTP handler that sends metrics each time an interval completes.