-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design part of our website has two different pages #2529
Comments
I have identified the issue as file routing. When accessing the URL https://armadaproject.io/design, it fetches design.md, whereas https://armadaproject.io/design/ fetches design/index.md. This discrepancy occurs because the browser interprets the trailing slash in the URL as the 'index' page. An optimal solution would be to set up a redirect from https://armadaproject.io/design to https://armadaproject.io/design/ and remove design.md since this wouldn't break any links relying on https://armadaproject.io/design while also creating only a single file to update whenever changes occur. A sub-optimal fix would be to update design.md. However, this would lead to both files needing to be maintained whenever an update occurs. As this is my first contribution to the project, I'm unsure about the underlying technology that controls routing. I would appreciate guidance on how to implement a fix to address this file routing issue. Thank you for your assistance. |
Hi @JosephHuntley! The underlying technology is Github pages, and they are served from their own branch: gh-pages. Hope that helps. |
@JosephHuntley are you working on this issue? If not, I would like to work on it. |
@ShivangShandilya My apologies, yes feel free. I'm unsure how to fix the issue without using JS to redirect the page. |
Hey if anyone is not workin on this issue can I take this @kannon92, assign it to me! |
@ShivangShandilya are you working on this issue? if not, I would like to work on it. |
Yup mate I'll be done with this soon, been busy with my GSoC project. If I'm not able to do this I'll surely pass on this to you |
@ShivangShandilya Any update? |
Yeah right so I proposed that I might have found the solution for this before to Kevin. It was this: Link to header.html file: https://github.com/armadaproject/armada/blob/gh-pages/_includes/header.html |
@ShivangShandilya Nice spot! Feel free to make the PR |
Describe the bug
If you browse to https://armadaproject.io/design/ you can see the relationships doc that @Sharpz7 added.
But if you click design via website (https://armadaproject.io/design), it will not have the relationships doc.
Files Or Markdown that can reproduce the issue
Expected behavior
I would expect that we should have https://armadaproject.io/design/ behavior in both cases.
┆Issue is synchronized with this Jira Task by Unito
The text was updated successfully, but these errors were encountered: